]> dgit.raspbian.org Git - gnome-shell.git/commit
workspace: Handle window-added and removed signal after window tracker
authorSebastian Keller <skeller@gnome.org>
Tue, 2 Feb 2021 21:31:32 +0000 (22:31 +0100)
committerSebastian Keller <skeller@gnome.org>
Tue, 2 Feb 2021 22:11:06 +0000 (23:11 +0100)
commit454394a267ba94492c14c2e1de720e5fc78483bd
tree227b1a7bcaf85aa5d1afd21651b6c972d8d36661
parent9ce666ac13d264ad31d871e2dd86b40066eda622
workspace: Handle window-added and removed signal after window tracker

The new window preview overlay requires getting the app icon for a
window from the window tracker when it gets initialized. The window
tracker listens for the same 'window-added' signal on the MetaWorkspace
that the gnome-shell Workspace listens for to add the window preview.

The window tracker however reconnects all its signal handlers whenever
the number of workspaces changes, which means that its signal handlers
get called after the ones in Workspace ones. So by the time the
'window-added' handler in Workspace is called, the window tracker does
not have an app associated with the window.

To fix this ensure that all window related signal handlers in Workspace
are run after the ones in the window tracker.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3656

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1625>
js/ui/workspace.js